Welcome, Guest
Username: Password: Remember me
General discussions, feature requests for CodeTyphon Project and discussions that don't fit in any of the other specific CodeTyphon forum categories.
  • Page:
  • 1

TOPIC:

Bug reporting - what's the right way? 9 years 2 months ago #6747

  • Javor
  • Javor's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • M.Sc in Computer Science, (ex-)freelancer
  • Posts: 72
  • Thank you received: 8
Hello Sternas.

I've a question regarding bug reporting. Should I report here or via freepascal bugtracker. Curious, because I don't know how are Typhon distributions are built. Are they taken from SVN for example and re-packed or?
I've found some bugs in lNet, Shapes... and I'm not sure where to post regarding them. Hope you can guide me. Regarding lNet, I've contacted one of the creators and he fixed (I think) one of the bugs (actually it's a memory leak), but others still stay. That means I've to repair those bugs every time I update the product.

Thanks in advance and wish you all good.
Keep up the good work! :woohoo:

Regards,
Markov

Please Log in or Create an account to join the conversation.

Last edit: by Javor.

Bug reporting - what's the right way? 9 years 2 months ago #6748

  • Sternas Stefanos
  • Sternas Stefanos's Avatar
  • Offline
  • Moderator
  • Moderator
  • Ex Pilot, M.Sc, Ph.D
  • Posts: 4512
  • Thank you received: 1101
Sir
my suggestion:

for all pl_**** packages please report here
we make special forum area for this.
I think, all packages creators read our forum.

Now, if the problem is from compiler, please report to Freepascal bugtracker
PilotLogic Architect and Core Programmer

Please Log in or Create an account to join the conversation.

Last edit: by Sternas Stefanos.

Bug reporting - what's the right way? 9 years 2 months ago #6749

  • Javor
  • Javor's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • M.Sc in Computer Science, (ex-)freelancer
  • Posts: 72
  • Thank you received: 8
Thank you, Sir.

I think there should be a separate section or at least a topic soon, so people could find and post fast enough :), but here's what I've found so far:
************************************************
Package: pl_Shapes
Unit: TplShapeObjects
everywhere called function DrawArrowHead(canvas, ...) should be DrawArrowHead(acanvas, ..) in order to have a proper drawing of the arrow. In other words parameter 'canvas' should be 'acanvas'.

line #1247, 1250, 1542, 1545, 1605, 1607,
DrawArrowHead(canvas, ....
should be
DrawArrowHead(acanvas, ...

Just a suggestion: if you can add for example
private
    fArrowSize: byte;
    fArrowFill: Boolean;
public
    property ArrowSize: byte read fArrowSize write fArrowSize;
    property ArrowFill: boolean read fArrowFill write fArrowFill;
to all the shapes that has an ability to have an arrow drawn. At the moment arrow head size and fill is hard-coded. Code should be then
DrawArrowHead(acanvas, BtnPoints[1], BtnPoints[0], fArrowSize, fArrowFill);
instead of current
DrawArrowHead(acanvas, BtnPoints[1], BtnPoints[0], 5, True);
Example code I've provided above is for TplLine component.

************************************************
Package: pl_lNet
Unit: lhttp.pp
Test scenario:
using TLHTTPClientComponent, no matter created runtime by code or designtime on a form, if using ASocket.Disconnect() inside DoneInput event
procedure TfrmTest.LHTTPClientComponent1DoneInput(ASocket: TLHTTPClientSocket);
begin
  ASocket.Disconnect(); // <- if using this one!!!
end;
there is 1 unfreed block for every time .Disconnect method is executed.
In order to solve this lines #1000 and #1001
  if FCurrentInput <> nil then
    FreeAndNil(FCurrentInput);
should be commented.
I see almindor already fixed the other bugs I've found so far.

Also, regarding Typhon IDE, please Mr Sternas, fix the issue with missing main window. This happens when Typhon is minimized, then right-click on it on the task bar and close (OS: Windows).
Way to resolve:
<?xml version="1.0" encoding="utf-8"?>
<CONFIG>
  <Settings HeaderColor="536870912"/>
  <MainConfig>
    <Nodes ChildCount="4">
      <Item1 Name="MainIDE" Type="CustomSite" WindowState="Minimized">
...
should be
<?xml version="1.0" encoding="utf-8"?>
<CONFIG>
  <Settings HeaderColor="536870912"/>
  <MainConfig>
    <Nodes ChildCount="4">
      <Item1 Name="MainIDE" Type="CustomSite">
State Minimized for main window is not a good thing ;)

That's for now. Hope the information was useful and these minor bugs will be resolved.
Regards,
Markov

Please Log in or Create an account to join the conversation.

Last edit: by Javor.

Bug reporting - what's the right way? 9 years 2 months ago #6753

  • Sternas Stefanos
  • Sternas Stefanos's Avatar
  • Offline
  • Moderator
  • Moderator
  • Ex Pilot, M.Sc, Ph.D
  • Posts: 4512
  • Thank you received: 1101
Thanks Sir
we fix/update pl_Shapes pkg

PS: please next time post to correct (pl_Shapes) forum Session :blush:
PilotLogic Architect and Core Programmer
Attachments:
The following user(s) said Thank You: Javor

Please Log in or Create an account to join the conversation.

Last edit: by Sternas Stefanos.

Bug reporting - what's the right way? 9 years 2 months ago #6758

  • Javor
  • Javor's Avatar Topic Author
  • Offline
  • Junior Member
  • Junior Member
  • M.Sc in Computer Science, (ex-)freelancer
  • Posts: 72
  • Thank you received: 8
Sorry about that, should of post the suggestion in the correct section. Thanks for the fast reaction :)

P.S. N.B. for those, who download the corrected package and use CT 5.20 and not the Lab version (at least not below Release 2015-01-29 Revision: 005211), please correct the following:
in file pl_shapes.lpk, line 71
<PackageName Value="bs_ideintf"/>
should become
<PackageName Value="IDEIntf"/>
as package still exists with its old name and you'll get an error: "Error: The following package failed to load: bs_ideintf"

Please Log in or Create an account to join the conversation.

Last edit: by Javor. Reason: Add correct package name to the post
  • Page:
  • 1